This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
feat: use sdk for unit denomination and conversion #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudleyneedham
suggested changes
Oct 1, 2020
LeonFLK
force-pushed
the
lw-749-sdk-unit-conversions
branch
from
a9543df
to
e18a10d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#749
Removes the demo-client based unit denominations and conversions and instead uses the sdk based utils.
How to test:
publish local sdk
start local demo client and services and check for units and balance behaviour.
Checklist: