Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

refactor: quote can be sent with submit terms #291

Merged
merged 2 commits into from
Oct 1, 2020
Merged

refactor: quote can be sent with submit terms #291

merged 2 commits into from
Oct 1, 2020

Conversation

Dudleyneedham
Copy link
Member

@Dudleyneedham Dudleyneedham commented Oct 1, 2020 •
edited
Loading

fixes https://github.com/KILTprotocol/ticket/issues/743

Originally, we had to have a delegation or an attested claim to be able to send the submit terms.

How to test:

Run through sending a quote.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@LeonFLK
Copy link
Contributor

LeonFLK commented Oct 1, 2020

LBTM

LeonFLK
LeonFLK approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@LeonFLK LeonFLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

@Dudleyneedham Dudleyneedham merged commit 2f5ea1c into develop Oct 1, 2020
@Dudleyneedham Dudleyneedham deleted the quote-only-submit-terms branch October 1, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeonFLK LeonFLK LeonFLK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dudleyneedham @LeonFLK