This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
feat: MultiTx & SDK Compatibility, non re-try #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwelde
changed the title
tjwelde
reviewed
Dec 3, 2020
| import { | ||
| IS_IN_BLOCK, | ||
| submitSignedTx, | ||
| } from '@kiltprotocol/sdk-js/build/blockchain/Blockchain' |
There was a problem hiding this comment.
hmm, this import is a bit ugly. we should work on a better export in the sdk
|
Restructured and exported here: KILTprotocol/sdk-js#315 |
tjwelde
suggested changes
Dec 4, 2020
|
Overall I think it improved the code much more. I feared, that the way |
tjwelde
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to KILTProtocol/ticket#853
Adds compatibility for the multitx functionalities, does not use re-try functionality, waits for IS_IN_BLOCK.
Checklist: