Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

feat: DID fetch on creating an identity #318

Merged
merged 3 commits into from
Jan 29, 2021
Merged

feat: DID fetch on creating an identity #318

merged 3 commits into from
Jan 29, 2021

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/1020

At the moment we don't check if an identity has a DID when adding the identity to the Demo-client

How to test:

Add an identity with tokens to generate a DID.
Delete said identity and re-add with a mnemonic.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

src/containers/WalletAdd/WalletAdd.tsx Outdated Show resolved Hide resolved
src/services/DidService.ts Outdated Show resolved Hide resolved
src/containers/WalletAdd/WalletAdd.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjwelde tjwelde merged commit fbb7141 into develop Jan 29, 2021
@tjwelde tjwelde deleted the dn-did-fetch branch January 29, 2021 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants