Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

feat: added did register to dashboard #324

Merged
merged 8 commits into from
Feb 2, 2021

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/1038

Added button to register and delete DID on the dashboard.
Change the store management of selected Identities with the wallet.
Fixed issues of the selected wallet being undefined. Now throws an error if selected identity not handled.

How to test:

Add and delete a did within the dashboard.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good already

src/services/ClientVersionHelper.ts Outdated Show resolved Hide resolved
src/containers/WalletAdd/WalletAdd.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dudleyneedham Dudleyneedham merged commit fa7bb2d into develop Feb 2, 2021
@Dudleyneedham Dudleyneedham deleted the dn-did-register-dashboard branch February 2, 2021 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants