This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
fix: display attestation status in claims list #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudleyneedham
added a commit
that referenced
this pull request
Apr 30, 2021
* chore: upgrade kilt sdk * fix: new tx workflow * fix: balances * fix: new RequestClaimsForCtypes format * fix: filter out incompatible messages * chore: update sdk * feat: updating to the latest rc 4 * feat: updating to the latest rc 5 * feat: updating to the latest rc 7 * fix: display attestation status in claims list (#348) * fix: delegation revoke signandsend (#349) * chore: bump sdk rc * chore: upgrading to the latest sdk rc * chore: releasing newest version Co-authored-by: dudleyneedham <dudleyneedham1993@gmail.com> Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com> Co-authored-by: LeonFLK <51441505+LeonFLK@users.noreply.github.com> Co-authored-by: LeonFLK <leon@kilt.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#1269
Fixes an issue where the revocation status was not correctly displayed in the claims list because the state was updated incorrectly.
This is the result of a state update before the fix:
As you can see, the
revokedproperty was set on the wrong object, one level too high.How to test:
Attest a claim, revoke it, then navigate to the claims list. While the revoked claim may still show a green check mark, it should switch to a red
xafter you entered the claim detail view once (clicking on the claim alias, then going back to the list view).Checklist: