Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ctype schema id ipns uri #70

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented May 3, 2022

fixes KILTProtocol/ticket#1917

Updates docs to align with changes of KILTprotocol/sdk-js#524
Only works after this has been merged and released.

How to test:

N/A

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@rflechtner rflechtner requested review from tjwelde and trusch May 3, 2022 13:10
@ntn-x2
Copy link
Member

ntn-x2 commented May 12, 2022

@rflechtner I can't seem to be able to resolve the IPNS link to get the document.

@rflechtner rflechtner marked this pull request as draft May 12, 2022 14:01
@rflechtner
Copy link
Contributor Author

@rflechtner I can't seem to be able to resolve the IPNS link to get the document.

Ah yes, i forgot to convert this to a draft PR. We will probably not use ipns in the end, it ultimately does not seem too well suited for the job

@weichweich weichweich changed the base branch from develop to master July 4, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants