feat: thicken the scrollbars & make 'em interactive for mobile (#764)

KRTirtho · Sep 30, 2023 · 84a4bcd · 84a4bcd
1 parent b1d7942
commit 84a4bcd
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 10 deletions.
diff --git a/lib/components/shared/track_table/tracks_table_view.dart b/lib/components/shared/track_table/tracks_table_view.dart
@@ -71,6 +71,8 @@ class TracksTableView extends HookConsumerWidget {
     final searchController = useTextEditingController();
     final searchFocus = useFocusNode();
 
+    final controller = useScrollController();
+
     // this will trigger update on each change in searchController
     useValueListenable(searchController);
 
@@ -210,14 +212,16 @@ class TracksTableView extends HookConsumerWidget {
                           }
                         case "add-to-playlist":
                           {
-                            await showDialog(
-                              context: context,
-                              builder: (context) {
-                                return PlaylistAddTrackDialog(
-                                  tracks: selectedTracks.toList(),
-                                );
-                              },
-                            );
+                            if (context.mounted) {
+                              await showDialog(
+                                context: context,
+                                builder: (context) {
+                                  return PlaylistAddTrackDialog(
+                                    tracks: selectedTracks.toList(),
+                                  );
+                                },
+                              );
+                            }
                             break;
                           }
                         case "play-next":
@@ -348,11 +352,16 @@ class TracksTableView extends HookConsumerWidget {
     if (isSliver) {
       return SliverSafeArea(
         top: false,
-        sliver: SliverList(delegate: SliverChildListDelegate(children)),
+        sliver: SliverList(
+          delegate: SliverChildListDelegate(children),
+        ),
       );
     }
     return SafeArea(
-      child: ListView(children: children),
+      child: ListView(
+        controller: controller,
+        children: children,
+      ),
     );
   }
 }
diff --git a/lib/themes/theme.dart b/lib/themes/theme.dart
@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter_desktop_tools/flutter_desktop_tools.dart';
 
 ThemeData theme(Color seed, Brightness brightness, bool isAmoled) {
   final scheme = ColorScheme.fromSeed(
@@ -68,5 +69,14 @@ ThemeData theme(Color seed, Brightness brightness, bool isAmoled) {
         ),
       ),
     ),
+    scrollbarTheme: DesktopTools.platform.isMobile
+        ? const ScrollbarThemeData(
+            interactive: true,
+            thickness: MaterialStatePropertyAll(18),
+            minThumbLength: 20,
+          )
+        : const ScrollbarThemeData(
+            thickness: MaterialStatePropertyAll(14),
+          ),
   );
 }