-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse xml string from RAM #1
Conversation
I noticed the build on travis failed, the test cases seem to fail every now and then.. if you run the code yourself though and cargo test a few times, should work.. |
Hi @primordus ! I didn't get a reply to my last email to @jfschaefer , so I am unsure if he has time to maintain this wrapper. For now I have gone and added the extra features I need to a fork here: It ended up in a significant rewrite (you may be heading in a different direction). I'll add the equivalent changes to your PR changes there by hand, while we're waiting for @jfschaefer to take a look. |
Hello @dginev, that's great news! |
Hi again - indeed useful API methods to add! I am quite happy to report I have integrated them with my fork, see commit: https://github.com/dginev/rust-libxml/commit/63f11995e83166d840b6b458f45bd6393c096cc1 I have refactored the wrapper to have the XML/HTML distinction happen as a property of the Parser object, which feels a bit cleaner. And made some of the setup/cleanup magic a bit more automatic, which seems to be largely working out as intended. Feel free to take a look and use that if you prefer. |
Thanks, I will probably use your fork instead then! Hope @jfschaefer some day will pull in our changes :).. |
This PR got merged a bit indirectly, so I'll close here - the commits are already in master. |
Added support for parsing of an XML string from a Rust str (previously only bindings were provided to parse from a file).
Also fixed the tests (hopefully in a correct way 😄), cleaned up some warnings, probably a remainder from older Rust versions..
P.S. some tests seem to fail sometimes, may be worth looking into? (even if you hate writing them ;))