Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import_node to Document #17

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

triptec
Copy link
Collaborator

@triptec triptec commented Nov 7, 2017

I need to copy a node from one document to another and this seems to be the function I need.

@dginev
Copy link
Member

dginev commented Nov 7, 2017

Looks great! Let me know if you also need crates.io minor releases, whenever tracking the master of the repository isn't sufficient anymore.

@dginev dginev merged commit 11854e1 into KWARC:master Nov 7, 2017
@triptec
Copy link
Collaborator Author

triptec commented Nov 7, 2017

I think I'll track the master for now.
Is it just me or is the xml manipulation libraries in rust a little immature?

@dginev
Copy link
Member

dginev commented Nov 7, 2017

Well yes, indeed! Them being a little immature is the exact reason this wrapper exists - I am perfectly happy to see rust-libxml fade away into obscurity one day, but until the Rust libraries are as impressive as the old-but-gold libxml2 library, this wrapper can be a useful stopgap.

I am hoping the main Rust-native XML libraries are moving forward fast however, I haven't checked recently since my main XML munging needs are at present satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants