-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace static mutex #3
Conversation
so we can compile on rust stable
Btw a good idea is to start using both stable and nightly on Travis from this PR on, and possibly even beta. In the end the core idea is to make the crate work on more rust releases, rather than less. |
And the 3 projects I am involved with that use this crate are all based on the nightly toolchain, so breaking that here would be a no-go. |
What should I put in the travis file? |
Based on the travis docs I'd suggest:
|
Thanks, I'll try that. Nightly tests successfully on my machine, btw. |
Strange, works on 1.8 nightly on macos |
The joys of travis. I'll take a look a bit later today if you don't find an obvious cause for the travis failure. |
Can we set |
I just installed today's nightly and it broke not only your PR but also the main rust-libxml master. So not a problem for your PR, we should fix it in master first. |
FYI it seems that xmlReadFile and htmlReadFile are now returning null pointers in the test suite. |
@ramn I merged a fix that brings us up to date with the current nightly, would you care to rebase the PR on the latest master? I'll look into it then (Travis should pass) |
So that we can compile on stable rust