Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static mutex #3

Closed
wants to merge 4 commits into from
Closed

Conversation

ramn
Copy link
Contributor

@ramn ramn commented Feb 23, 2016

So that we can compile on stable rust

so we can compile on rust stable
@ramn ramn mentioned this pull request Feb 23, 2016
@dginev
Copy link
Member

dginev commented Feb 23, 2016

Btw a good idea is to start using both stable and nightly on Travis from this PR on, and possibly even beta. In the end the core idea is to make the crate work on more rust releases, rather than less.

@dginev
Copy link
Member

dginev commented Feb 23, 2016

And the 3 projects I am involved with that use this crate are all based on the nightly toolchain, so breaking that here would be a no-go.

@ramn
Copy link
Contributor Author

ramn commented Feb 23, 2016

What should I put in the travis file?

@dginev
Copy link
Member

dginev commented Feb 23, 2016

Based on the travis docs I'd suggest:

language: rust
rust:
  - stable
  - beta
  - nightly

@ramn
Copy link
Contributor Author

ramn commented Feb 23, 2016

Thanks, I'll try that. Nightly tests successfully on my machine, btw.

@ramn
Copy link
Contributor Author

ramn commented Feb 23, 2016

Strange, works on 1.8 nightly on macos

@dginev
Copy link
Member

dginev commented Feb 23, 2016

The joys of travis. I'll take a look a bit later today if you don't find an obvious cause for the travis failure.

@ramn
Copy link
Contributor Author

ramn commented Feb 23, 2016

Can we set RUST_BACKTRACE=1?

@dginev
Copy link
Member

dginev commented Feb 23, 2016

I just installed today's nightly and it broke not only your PR but also the main rust-libxml master. So not a problem for your PR, we should fix it in master first.

@dginev
Copy link
Member

dginev commented Feb 24, 2016

FYI it seems that xmlReadFile and htmlReadFile are now returning null pointers in the test suite.

@dginev
Copy link
Member

dginev commented Feb 24, 2016

@ramn I merged a fix that brings us up to date with the current nightly, would you care to rebase the PR on the latest master? I'll look into it then (Travis should pass)

@ramn ramn mentioned this pull request Feb 24, 2016
@ramn
Copy link
Contributor Author

ramn commented Feb 24, 2016

@ramn ramn closed this Feb 24, 2016
@ramn ramn deleted the replace_static_mutex branch February 24, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants