Fix Issue #33 #55
Merged
Fix Issue #33 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2019 13:21
…h non-BMP Unicode characters.
dginev
reviewed
Jun 16, 2019
|
|
||
|
|
||
| ///Convert usize to i32 safely. | ||
| fn usize_to_i32(value: usize) -> Result<i32, XmlParseError> { |
There was a problem hiding this comment.
Cool handler, just reread and saw the Result type. I wonder if a more explicit name would be try_usize_to_i32 to indicate the Result return type, but that's just thinking out loud for now.
There was a problem hiding this comment.
I like that a lot, actually. It fits with the naming conventions from the TryFrom trait, making it signify its intent exactly.
|
I'm very grateful for the extended test suite, thanks for the upgrade! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comprehensive fix for issue #33. As I have not yet received any comments from this, I am tentatively submitting a PR for this patch. Please see the issue tracker for comments on this patch.