Document to string with save options #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dginev
reviewed
Sep 26, 2019
src/tree/document.rs
Outdated
| @@ -171,26 +213,51 @@ impl Document { | |||
| } | |||
|
|
|||
| /// Serializes the `Document` | |||
| pub fn to_string(&self, format: bool) -> String { | |||
| pub fn to_string(&self) -> String { | |||
There was a problem hiding this comment.
You can entirely remove the to_string definition here, it is auto-generated by the fmt::Display implementation
dginev
reviewed
Sep 26, 2019
| (*xml_indent_tree_output_ptr) = indent; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Excellent to see this removed, thanks!
|
Thanks @jangernert ! This looks good to merge after you simply delete the explicit |
|
Thanks, glad to have the upgrade! |
|
Cool! Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlSaveOption:to_string_with_optionsto_stringsince it is covered by the new methodcargo fmtand can be reverted if needed