Merge pull request #44 from shinnoki/feature/fix-replace-minimizer

Fix replaceMinimizer to preserve the original config
Karibash · Oct 1, 2022 · bfaca66 · bfaca66
2 parents 154060c + 8866f93
commit bfaca66
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/.changeset/nervous-penguins-remember.md b/.changeset/nervous-penguins-remember.md
@@ -0,0 +1,5 @@
+---
+"storybook-addon-swc": patch
+---
+
+Fix replaceMinimizer to preserve the original config (Fix #43)
diff --git a/src/transformers.ts b/src/transformers.ts
@@ -68,6 +68,7 @@ export const replaceMinimizer = (options: JsMinifyOptions): (config: Configurati
   return (config: Configuration) => ({
     ...config,
     optimization: {
+      ...config.optimization,
       minimizer: 0 < config.optimization?.minimizer?.length
         ? [new TerserPlugin({
             minify: TerserPlugin.swcMinify,

diff --git a/test/transformers.test.ts b/test/transformers.test.ts
@@ -306,6 +306,11 @@ describe('replaceMinimizer', () => {
     const minimizer = config.optimization?.minimizer?.find(minimizer => minimizer instanceof TerserPlugin);
     expect(minimizer.options.minimizer.implementation.name).toEqual('swcMinify');
   });
+
+  it('Preserve the rest optimization config other than minimizer', () => {
+    const config = transformer({ optimization: { moduleIds: 'named', minimizer: [] } });
+    expect(config).toEqual({ optimization: { moduleIds: 'named', minimizer: [] } });
+  });
 });
 
 describe('disableSourceMap', () => {