Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sysctl parsing in lab.conf for negative values #226

Closed
tcaiazzi opened this issue Jul 7, 2023 · 0 comments
Closed

Fix sysctl parsing in lab.conf for negative values #226

tcaiazzi opened this issue Jul 7, 2023 · 0 comments

Comments

@tcaiazzi
Copy link
Member

tcaiazzi commented Jul 7, 2023

The current implementation of sysctl parsing in the lab.conf raises an exception when handling negative values.

Specifically, when a negative value is specified for a sysctl parameter, such as net.ipv6.conf.default.seg6_require_hmac=-1, the parsing mechanism fails, raising the exception MachineOptionError.

To address this issue, we need to modify the sysctl parsing logic in the lab.conf file to handle negative values appropriately.
The parsing mechanism should recognize negative values and assign them correctly to the corresponding sysctl parameter.

@tcaiazzi tcaiazzi added this to the Release 3.6.5 milestone Jul 7, 2023
@tcaiazzi tcaiazzi changed the title Fix sysctl parsing in lab.conf for negative values Fix sysctl parsing in lab.conf for negative values Jul 7, 2023
@Skazza94 Skazza94 self-assigned this Jul 8, 2023
@Skazza94 Skazza94 closed this as completed Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants