Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for keyUp in 3.0 #102

Closed
gcox opened this issue Sep 22, 2019 · 0 comments
Closed

Restore support for keyUp in 3.0 #102

gcox opened this issue Sep 22, 2019 · 0 comments

Comments

@gcox
Copy link

gcox commented Sep 22, 2019

Prior to 3.0, a single hot key could be setup that conveniently allowed for both the keyUp and keyDown events to be handled. (#18)

Unfortunately, this feature got lost in the 3.0 update. The use case presented in the PR above is still perfectly valid.
gcox added a commit to gcox/ShortcutRecorder that referenced this issue Sep 22, 2019
@gcox
Restores support for keyUp; Kentzo#102
6a1e187
@gcox gcox mentioned this issue Sep 22, 2019
Closed
gcox added a commit to gcox/ShortcutRecorder that referenced this issue Sep 29, 2019
@gcox
Revert "Restores support for keyUp; Kentzo#102"
c274dd1 
This reverts commit 6a1e187.
Kentzo pushed a commit that referenced this issue Oct 12, 2019
@gcox @Kentzo
Restores support for keyUp; #102
1157879 
Cleaner implementation that allows SRShortcutAction's to be created with a `forKeyEvent` property that allows for handling of one of `kEventHotKeyPressed` or `kEventHotKeyReleased`. The default is `kEventHotKeyPressed`.
Kentzo added a commit that referenced this issue Oct 12, 2019
@Kentzo
Merge pull request #105 from Kentzo/gcox-restore-keyup-support
b9b722d 
Closes #102
@Kentzo Kentzo closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restores support for keyUp/kEventHotKeyReleased gcox/ShortcutRecorder
2 participants
@Kentzo @gcox