Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 10 #103

Merged
merged 9 commits into from
Sep 28, 2018
Merged

Issue 10 #103

merged 9 commits into from
Sep 28, 2018

Conversation

SooDevv
Copy link
Collaborator

@SooDevv SooDevv commented Sep 20, 2018

오타 고치고, feedback 반영하여 수정하고 추가할 부분은 > 이렇게 추가하였습니다!
pull request 이런식으로 하는게 맞나요?

@MijeongJeon
Copy link
Member

MijeongJeon commented Sep 28, 2018 •
edited
Loading

수정님 수고많으셨습니다!

  • 커밋메세지를 작성할때 #과 숫자는 붙여서 # 10 --> 딥러닝의 Hello World , Fashion-MNIST #10 으로 작성해주세요~
  • 포크해간 레포에서 작업해도 괜찮지만 이왕이면 여기 레포에서 브랜치 issue_10 만들어서 작업해주세요~
  • 풀리퀘를 close 하지 않고 오픈한 상태에서 수정하셔도 괜찮습니다 👍

@MijeongJeon
#10: 문장 수정(띄어 쓰기 및 번역투 문구)
71ca44a 
* 영어 단어 뒤에 오는 조사는 붙여쓰기로 변경
* 번역투의 문장 수정
MijeongJeon
MijeongJeon approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@MijeongJeon MijeongJeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정님~ 제가 수정(!!)한 부분 확인해보시고 괜찮다고 커멘트 남겨주시면 머지하겠습니다!
수고많으셨어요!

@SooDevv
Copy link
Collaborator Author

SooDevv commented Sep 28, 2018

수정하신 부분 다 확인했습니다. 꼼꼼한 확인 감사합니다!

@MijeongJeon MijeongJeon merged commit 22140e0 into KerasKorea:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MijeongJeon MijeongJeon MijeongJeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SooDevv @MijeongJeon