Fixes a bug introduced in 7.0.12/13 to specify the objectType in calls to EntityService.GetAll #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJump
added a commit
that referenced
this pull request
Jul 14, 2019
adds extra baseObjectType value so we can set the type of things we are looking up (because media mapper looks up Media)
KevinJump
added a commit
that referenced
this pull request
Jul 14, 2019
Like the Mapper, the base serializer lookup can be used for ContentTypes, MediaTypes and MemberTypes
KevinJump
added a commit
that referenced
this pull request
Jul 14, 2019
KevinJump
added a commit
that referenced
this pull request
Jul 14, 2019
KevinJump
added a commit
that referenced
this pull request
Jul 14, 2019
* Fixes to specify the objectType in calls to EntityService.GetAll (#225) thanks, there is a minor annoyance that the MediaIdMapper inherits the content one, so sometimes the lookup is for media, not content, but I will fix that. * set baseObjectType for class so MediaMapper can use it too. #225 adds extra baseObjectType value so we can set the type of things we are looking up (because media mapper looks up Media) * Base type in ContentType Serializer #225 Like the Mapper, the base serializer lookup can be used for ContentTypes, MediaTypes and MemberTypes * update RjpMapper to do the getall lookup properly (like #225) * Refactor RJP Mapper to use GetKeyForId / GetIdForKey EntityService calls * tidy up, use GetIdForKey and GetKeyForId where we can #225 * ID Testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was calling EntityService.GetAll(Guid objectType) which gets all entities of that object type, which is not what was intended.
This PR specifies the object type explicitly, and passes the ID as a second parameter (single-item array).