Skip to content

Commit

Permalink
tools: remove no-goma arg from make-v8 script
Browse files Browse the repository at this point in the history
V8 recently removed its support and passing it makes canary builds
fail. It should be safe to remove it now as the default behavior is to
look for goma in the PATH, and CI hosts shouldn't have goma installed.

Refs: v8/v8@6c5a6c0
PR-URL: nodejs#53336
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
targos committed Jun 6, 2024
1 parent 4648185 commit 68c9f55
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/make-v8.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
else
DEPOT_TOOLS_DIR="$(cd _depot_tools && pwd)"
# shellcheck disable=SC2086
PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" $V8_BUILD_OPTIONS
PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" "${JOBS_ARG}" d8 cctest inspector-test
fi

0 comments on commit 68c9f55

Please sign in to comment.