Align support for multiple operation-files and multiple schema-files #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple schema-files are now supported as of #134, but the support was a bit different from how we did multiple operation-files. Before anyone starts to depend on the ways the syntaxes differ, let's just make them the same. Since it's easy, I also added support for having just a single operations-file. Test plan: make check
csilvers
reviewed
Oct 5, 2021
csilvers
reviewed
Oct 5, 2021
| } | ||
|
|
||
| for _, m := range matches { | ||
| if schemas.Has(m) { |
There was a problem hiding this comment.
You can probably get rid of the Has function too.
csilvers
approved these changes
Oct 5, 2021
|
cc @hsblhsn if you wanted to take a look! If it's an issue we could move to using the fancier globbing for both. |
hsblhsn
suggested changes
Oct 5, 2021
Comment on lines
-26
to
+36
| filename, _ := graphqlError.Extensions["file"].(string) | ||
| return nil, errorf(nil, "invalid schema file %v: %v", filename, graphqlError) | ||
| return nil, errorf(nil, "invalid schema: %v", graphqlError) |
There was a problem hiding this comment.
Removing file name from error message will make it really hard to find issues in schema or operation files. Since we still do not have strong IDE support for graphql SDL files.
WDYT?
| testdata/errors/InvalidSchema.schema.graphql:4: invalid schema file testdata/errors/InvalidSchema.schema.graphql: Expected :, found } | ||
| testdata/errors/InvalidSchema.schema.graphql:4: invalid schema: Expected :, found } |
There was a problem hiding this comment.
Finding the exact issue will be tough just by seeing the new error message. Previous message was better IMO.
There was a problem hiding this comment.
I think the filename is still there, just in a different place:
testdata/errors/InvalidSchema.schema.graphql:4: invalid schema: Expected :, found }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
There was a problem hiding this comment.
Opps, sorry I missed it. LGTM now!
hsblhsn
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple schema-files are now supported as of #134, but the support was
a bit different from how we did multiple operation-files. Before anyone
starts to depend on the ways the syntaxes differ, let's just make them
the same. Since it's easy, I also added support for having just a
single operations-file.
I also realized while writing this that the type-change is technically
breaking (if you call from Go), so documented it as such. I think
this is unlikely to affect many people.
Test plan: make check