Use yaml.UnmarshalStrict #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Mark pointed out in a review where I realized that the *example* had a bogus config key (which I hadn't noticed earlier because it was just using the default value), we should probably do a strict-unmarshal; there's no reason you should have random extra keys in your config and if you do it's probably a mistake. (Or maybe you're running a too-old version of genqlient for your codebase, which you probably also want to know.) Now we do. Test plan: - `make check` - in webapp, `go mod edit -replace github.com/Khan/genqlient=../genqlient` then `make genqlient` produces no diffs (except go.mod/go.sum). Reviewers: csilvers, adam, marksandstrom, miguel
benjaminjkraft
requested review from
aberkan,
csilvers,
dnerdy and
MiguelCastillo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As Mark pointed out in a review where I realized that the example had
a bogus config key (which I hadn't noticed earlier because it was just
using the default value), we should probably do a strict-unmarshal;
there's no reason you should have random extra keys in your config and
if you do it's probably a mistake. (Or maybe you're running a too-old
version of genqlient for your codebase, which you probably also want to
know.) Now we do.
Test plan:
make checkgo mod edit -replace github.com/Khan/genqlient=../genqlientthen
make genqlientproduces no diffs (except go.mod/go.sum).