Add a new option to treat an interface like an object #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic idea here is if you only request interface fields (no fragments) you may not care about the concrete type, and so we could just generate a struct as if it were an object. I don't think it's a good idea to do that by default, because then if you later add a fragment all your code totally changes, but it's quite reasonable as an option! Most of the code involved is just wiring and validation; the core implementation is literally just: treat it like an object. Issue: #85 Test plan: make check Reviewers: csilvers, marksandstrom, jvoll, adam, mahtab, miguel
benjaminjkraft
requested review from
aberkan,
csilvers,
dnerdy,
jvoll,
mahtabsabet,
MiguelCastillo and
StevenACoffman
csilvers
reviewed
Sep 15, 2021
docs/FAQ.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Keep in mind that if you later want to add fragments to your selection, the types will change entirely. |
There was a problem hiding this comment.
Hmm, if you say struct: true and specify fragments, how does it work? Wouldn't it give an error?
There was a problem hiding this comment.
Yeah, I just mean it'll error so you'll have to change it. Will reword.
csilvers
reviewed
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The basic idea here is if you only request interface fields (no
fragments) you may not care about the concrete type, and so we could
just generate a struct as if it were an object. I don't think it's a
good idea to do that by default, because then if you later add a
fragment all your code totally changes, but it's quite reasonable as an
option!
Most of the code involved is just wiring and validation; the
core implementation is literally just: treat it like an object.
Issue: #85
Test plan:
make check