safestruct: Remove safe_VkDescriptorDataEXT #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-lunarg
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
At first I was confused cause the Pr is like "remove the reverted removal of safe_struct" but then I read the changes and everything made sense.
Still, the reality of 'making it not break right now' taking priority over 'making the correct fix later' leads to some fun change descriptions.
ziga-lunarg
approved these changes
Apr 24, 2024
spencer-lunarg
force-pushed
the
spencer-lunarg-codegen4
branch
from
13912b3
to
1ab00ab
Compare
y-novikov
referenced
this pull request
in KhronosGroup/Vulkan-ValidationLayers
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 2 of #196
This was removed in #201
but then fixed in KhronosGroup/Vulkan-ValidationLayers#7898
and this time it is ready to go