Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update to header 1.3.289 #223

Merged
merged 1 commit into from
Jun 28, 2024
Merged

build: Update to header 1.3.289 #223

merged 1 commit into from
Jun 28, 2024
+527 −5

Conversation

mikes-lunarg
Copy link
Contributor

No description provided.

@mikes-lunarg
Copy link
Contributor Author

@charles-lunarg Looks like I need to do something similar to this: KhronosGroup/Vulkan-Headers@e3c37e6

@charles-lunarg
Copy link
Collaborator

@charles-lunarg Looks like I need to do something similar to this: KhronosGroup/Vulkan-Headers@e3c37e6

You can just set -DVULKAN_HEADERS_ENABLE_MODULE=OFF for the time being.

@charles-lunarg
Copy link
Collaborator

If its causing CI to fail across the board, maybe updating Vulkan-Headers to set module support to OFF for the time being is the better option?

@mikes-lunarg
Copy link
Contributor Author

If its causing CI to fail across the board, maybe updating Vulkan-Headers to set module support to OFF for the time being is the better option?

It is easy enough to opt out of modules for a while, modifying the upstream defaults is more work at this point

@charles-lunarg
Copy link
Collaborator

Sounds good. Frankly, its just annoying that MSVC has fixed the bug but its not in the runners just yet.

@mikes-lunarg mikes-lunarg merged commit df78ee3 into main Jun 28, 2024
35 checks passed
@mikes-lunarg mikes-lunarg deleted the __release-1.3.289 branch June 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

@ziga-lunarg ziga-lunarg ziga-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikes-lunarg @charles-lunarg @ziga-lunarg