Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: Update 'create' criteria #4138

Closed

Conversation

ncesario-lunarg
Copy link
Contributor

Determine whether or not a command is expected to return a result in a
pointer based on parameter type rather than a hard-coded list of command
names.

Closes #4136.

Determine whether or not a command is expected to return a result in a
pointer based on parameter type rather than a hard-coded list of command
names.

Closes KhronosGroup#4136.
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 18022.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 7365 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 7365 passed.

Copy link
Contributor

@mikes-lunarg mikes-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the spec a little closer, it looks like this is not the right approach.

vkGetWinrtDisplayNV is not a create call. It should return the same handle when called multiple times with the same arguments, and the returned handle should be one of the VkDisplayKHR handles enumerated by vkGetPhysicalDeviceDisplayPropertiesKHR. Check out ValidationObject::WrapDisplay and Validation::MaybeWrapDisplay to see some of the existing code deal with these handles.

@ncesario-lunarg
Copy link
Contributor Author

Then perhaps rather than an "allow list," we should have a "block list" of commands that return pointers that should not be wrapped?

@mikes-lunarg
Copy link
Contributor

Sure, we sort of already have that with no_autogen_list which is how it looks like we deal with the existing parts of the API which touch VkDisplayKHR handles (paired with a custom wrapping/unwrapping implementation). It would be really great if we could generalize the VkDisplayKHR wrapping codegen and get rid of the custom implementations since these handles have popped up in a few new extensions now.

@juan-lunarg
Copy link
Contributor

@ncesario-lunarg could you rebase this PR?

It's using the old CI flow which is impacting up the github actions cache.

@juan-lunarg
Copy link
Contributor

Closing due to age / staleness / impacting CI caching

If still valuable please open new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layer_chassis_dispatch.cpp attempts to unwrap output handles
4 participants