Improve Layer Chassis Dispatch script #7740
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 154931. |
| @@ -340,60 +340,6 @@ void DispatchDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const V | |||
| layer_data->renderpasses_states.erase(renderPass); | |||
| } | |||
|
|
|||
| VkResult DispatchCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, | |||
There was a problem hiding this comment.
these are handled correctly now in the code gen, they were on the top of the "no autogen" list so probably added well before the script was improved over the years
| @@ -902,7 +848,7 @@ VkResult DispatchGetPhysicalDeviceDisplayPropertiesKHR(VkPhysicalDevice physical | |||
| if (!wrap_handles) return result; | |||
| if ((result == VK_SUCCESS || result == VK_INCOMPLETE) && pProperties) { | |||
| for (uint32_t idx0 = 0; idx0 < *pPropertyCount; ++idx0) { | |||
| pProperties[idx0].display = layer_data->MaybeWrapDisplay(pProperties[idx0].display, layer_data); | |||
| pProperties[idx0].display = layer_data->MaybeWrapDisplay(pProperties[idx0].display); | |||
There was a problem hiding this comment.
cleaned up MaybeWrapDisplay logic, it is called from layer_data so didn't need it passed in as well
| @@ -1006,18 +951,6 @@ VkResult DispatchGetDisplayModeProperties2KHR(VkPhysicalDevice physicalDevice, V | |||
| return result; | |||
| } | |||
|
|
|||
| VkResult DispatchEnumerateDeviceExtensionProperties( | |||
There was a problem hiding this comment.
generated the same, removed from no-autogen list
|
CI Vulkan-ValidationLayers build # 16203 running. |
| @@ -1110,84 +1043,6 @@ VkResult DispatchGetPhysicalDeviceToolProperties(VkPhysicalDevice physicalDevice | |||
| return result; | |||
| } | |||
|
|
|||
| bool NotDispatchableHandle(VkObjectType object_type) { | |||
There was a problem hiding this comment.
this is the only thing that SetPrivate/GetPrivate calls had different, this is not all auto-generated (since we have information about which handles are dispatchable now
| @@ -1722,41 +1577,3 @@ VkResult DispatchReleasePerformanceConfigurationINTEL( | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| #ifdef VK_USE_PLATFORM_XLIB_XRANDR_EXT | |||
| VkResult DispatchGetRandROutputDisplayEXT(VkPhysicalDevice physicalDevice, Display* dpy, RROutput rrOutput, | |||
There was a problem hiding this comment.
these 3 VkDisplayKHR are now generated
| @@ -33,15 +33,16 @@ def __init__(self): | |||
| 'vkDestroyInstance', | |||
| 'vkCreateDevice', | |||
| 'vkDestroyDevice', | |||
| 'vkCreateSwapchainKHR', | |||
| 'vkCreateSharedSwapchainsKHR', | |||
| # Need to handle Acquired swapchain image handles | |||
There was a problem hiding this comment.
finally added a comment "why" we are not auto generating things
|
CI Vulkan-ValidationLayers build # 16203 passed. |
| return (HandleType)unique_id; | ||
| } | ||
|
|
||
| // Specialized handling for VkDisplayKHR. Adds an entry to enable reverse-lookup. | ||
| VkDisplayKHR WrapDisplay(VkDisplayKHR newlyCreatedHandle, ValidationObject* map_data) { | ||
| // VkDisplayKHR objects are statically created in the driver at VkCreateInstance. |
There was a problem hiding this comment.
Great comment, makes clear how the things work.
spencer-lunarg
force-pushed
the
spencer-lunarg-display-handle
branch
from
d0bf116
to
09d9bd1
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 155016. |
|
CI Vulkan-ValidationLayers build # 16207 running. |
|
CI Vulkan-ValidationLayers build # 16207 passed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-display-handle
branch
from
09d9bd1
to
6f42444
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 155037. |
|
CI Vulkan-ValidationLayers build # 16208 running. |
|
CI Vulkan-ValidationLayers build # 16208 passed. |
closes #4136
I have gone over all the various edge cases in the
layer_chassis_dispatch_generator.pyand feel confident it is in a good state now