Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to community versions. #30

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

dannys42
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

Copy link

@futurejones futurejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release versions you are referencing don't exist yet.
All the individual repos referenced need to have the new 200 releases before you can reference them in the package files.

@dannys42
Copy link
Contributor Author

@futurejones I did create tags, which I think is all that SPM cares for (note that CI did pass successfully). It's a good point that I hadn't checked GitHub releases, though. Is there really any reason to support them? I see that OpenSSL doesn't even have releases for many of the prior tags. Maybe just for major or minor releases, but not patch releases?

@futurejones
Copy link

I missed the tag which should be ok but I thought the purpose of the update was to reflect the change to the Kitura Organization?
Shouldn't we be doing a proper release with an explanation as to what the release is for?

@dannys42
Copy link
Contributor Author

I missed the tag which should be ok but I thought the purpose of the update was to reflect the change to the Kitura Organization?
Shouldn't we be doing a proper release with an explanation as to what the release is for?

Yeah, that's a good point. I'll start doing that.

@dannys42 dannys42 merged commit baf6ed3 into Kitura:master Oct 3, 2020
@dannys42 dannys42 deleted the MISC-CommunityVersion branch October 3, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants