-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add x_offset (Used to add horizontal offset on SSD1306/SH1106 displays) #3284
Merged
KevinOConnor
merged 4 commits into
Klipper3d:master
from
rjpatawaran:work-display-xoffset
Sep 10, 2020
Merged
config: Add x_offset (Used to add horizontal offset on SSD1306/SH1106 displays) #3284
KevinOConnor
merged 4 commits into
Klipper3d:master
from
rjpatawaran:work-display-xoffset
Sep 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default value for x_offset
Thanks for taking care of this! |
KevinOConnor
reviewed
Sep 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. See my comments below.
-Kevin
Just pushed changes based on your comments @KevinOConnor. RJ |
KevinOConnor
reviewed
Sep 8, 2020
Revert removal of space after analog_range_kill_pin
Thanks. -Kevin |
dmbutyugin
pushed a commit
to dmbutyugin/klipper
that referenced
this pull request
Sep 12, 2020
… displays) (Klipper3d#3284) Signed-off-by: RJ Patawaran <rjpatawaran@me.com>
tntclaus
pushed a commit
to tntclaus/klipper
that referenced
this pull request
Apr 18, 2021
… displays) (Klipper3d#3284) Signed-off-by: RJ Patawaran <rjpatawaran@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module: Display, add x_offset config
Fix for #3091
Adds a horizontal offset config for fixing displays that are cutoff
in Voron v0 printers.
Detail explanation here:
#3091 (comment)
Signed-off-by: RJ Patawaran rjpatawaran@me.com