Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add x_offset (Used to add horizontal offset on SSD1306/SH1106 displays) #3284

Merged
merged 4 commits into from
Sep 10, 2020

Conversation

rjpatawaran
Copy link
Contributor

module: Display, add x_offset config

Fix for #3091

Adds a horizontal offset config for fixing displays that are cutoff
in Voron v0 printers.

Detail explanation here:
#3091 (comment)

Signed-off-by: RJ Patawaran rjpatawaran@me.com

@john--
Copy link
Contributor

john-- commented Sep 6, 2020

Thanks for taking care of this!

Copy link
Collaborator

@KevinOConnor KevinOConnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See my comments below.

-Kevin

config/example-extras.cfg Outdated Show resolved Hide resolved
klippy/extras/display/uc1701.py Outdated Show resolved Hide resolved
klippy/extras/display/uc1701.py Outdated Show resolved Hide resolved
@rjpatawaran
Copy link
Contributor Author

rjpatawaran commented Sep 7, 2020

Just pushed changes based on your comments @KevinOConnor.

RJ

Revert removal of space after analog_range_kill_pin
@KevinOConnor KevinOConnor merged commit c7ea4b8 into Klipper3d:master Sep 10, 2020
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

dmbutyugin pushed a commit to dmbutyugin/klipper that referenced this pull request Sep 12, 2020
… displays) (Klipper3d#3284)

Signed-off-by: RJ Patawaran <rjpatawaran@me.com>
tntclaus pushed a commit to tntclaus/klipper that referenced this pull request Apr 18, 2021
… displays) (Klipper3d#3284)

Signed-off-by: RJ Patawaran <rjpatawaran@me.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants