Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config for Eryone Thinker Series #4096

Merged
merged 17 commits into from
Apr 7, 2021
Merged

Added config for Eryone Thinker Series #4096

merged 17 commits into from
Apr 7, 2021

Conversation

dapostol73
Copy link
Contributor

@dapostol73 dapostol73 commented Mar 23, 2021

Would like to add this config for others to use for an Eryone Thinker S. If this needs to be integrated to another branch, please let me know...thanks.

@KevinOConnor
Copy link
Collaborator

Thanks, but please see the guidelines (just recently added) for example config files: https://www.klipper3d.org/Example_Configs.html

Also, commits need to have a signed-off-by line - see: https://github.com/KevinOConnor/klipper/blob/master/docs/CONTRIBUTING.md

-Kevin

@dapostol73
Copy link
Contributor Author

Hey Kevin,

Thanks for the documentation and feedback, I believe I have resolved all issues, please let me know if you have any feedback.

Also, the automation tests are a great help!

-Demetrius

config/printer-eryone-thinker-series-v2.cfg Outdated Show resolved Hide resolved
config/printer-eryone-thinker-series-v2.cfg Outdated Show resolved Hide resolved
config/printer-eryone-thinker-series-v2.cfg Outdated Show resolved Hide resolved
Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
- Remove GCode overrides
- Added static_digital_output for steppers
- Added documentation for where to find custom settings.

Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
@KevinOConnor
Copy link
Collaborator

KevinOConnor commented Apr 7, 2021

Thanks. The config looks fine, but the filename should end in a year (as described at https://www.klipper3d.org/Example_Configs.html ).

No they are not, but their is feedback from the community that they would like these to be easier for none technical people to not have figure this out on their own....is it cool to have these commented out, similar to the BL Touch settings?

FWIW, we recently added a section to the Klipper Discourse server for sharing custom configs ( https://community.klipper3d.org/ ). So, if you want to add the basic config here and the advanced config on Discourse that would be fine.

Cheers,
-Kevin

Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
@KevinOConnor KevinOConnor merged commit bf01d6d into Klipper3d:master Apr 7, 2021
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@dapostol73
Copy link
Contributor Author

Thank you, for all your hard work...really enjoying Klipper

revilo196 pushed a commit to revilo196/klipper that referenced this pull request Apr 10, 2021
Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
tntclaus pushed a commit to tntclaus/klipper that referenced this pull request Apr 18, 2021
Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
driest pushed a commit to driest/klipper that referenced this pull request Apr 26, 2021
Signed-off-by: Demetrius Apostolopoulos <dapostol73@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants