Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for creality sermoon D1 printer #4621

Merged
merged 10 commits into from
Sep 25, 2021

Conversation

peterpanstechland
Copy link
Contributor

created a config support for creality sermoon D1 printer with option of adding bltouch.

@peterpanstechland
Copy link
Contributor Author

this printer come with a Creality-4.3.1 board.

@KevinOConnor
Copy link
Collaborator

Thanks. In general, the config looks good to me. However, commits need to have a signed-off-by line containing your full real name - https://github.com/KevinOConnor/klipper/blob/master/docs/CONTRIBUTING.md

Also, all the configs are added to the regression test case (as describe at https://www.klipper3d.org/Example_Configs.html ) and so the PID parameters need to be defined in the heater sections.

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Aug 31, 2021
Signed-off-by: Peter <twinkle-pirate@hotmail.com>
Signed-off-by: Shi Pan <twinkle-pirate@hotmail.com>
@peterpanstechland
Copy link
Contributor Author

Thanks Kevin,

I think the latest commit should have fixed all the requirements and followed the contributing guide lines, hopefully this config file could finally get merged.😉

-Peter

@KevinOConnor
Copy link
Collaborator

Thanks, but this doesn't look like it will pass the regression test cases as the pid parameters aren't defined in the heater_bed config section. Also, the PID parameters should use option: value instead of option = value syntax (as described in the document above).

-Kevin

@peterpanstechland
Copy link
Contributor Author

Thanks, but this doesn't look like it will pass the regression test cases as the pid parameters aren't defined in the heater_bed config section. Also, the PID parameters should use option: value instead of option = value syntax (as described in the document above).

-Kevin

Sorry, I think I've used someone's sample fork, didn't pay attention on the format, will fix that by next commit.

-Peter

@KevinOConnor KevinOConnor merged commit f3d7084 into Klipper3d:master Sep 25, 2021
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

asenci pushed a commit to asenci/klipper that referenced this pull request Oct 4, 2021
Signed-off-by: Shi Pan <twinkle-pirate@hotmail.com>
troy-jacobson pushed a commit to troy-jacobson/klipper that referenced this pull request Nov 22, 2021
Signed-off-by: Shi Pan <twinkle-pirate@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants