Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in config option name #4981

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

usrhere
Copy link
Contributor

@usrhere usrhere commented Nov 30, 2021

I believe I've found typo in docs

Signed-off-by: Joseph Vilimas 4to5@protonmail.com

@dmbutyugin
Copy link
Collaborator

Thanks, indeed this is a typo. Separately, please note that all commits need to have a Signed-off-by line with a full real name.

@usrhere
Copy link
Contributor Author

usrhere commented Dec 1, 2021

Ok, thanks, now it's fully signed.

@dmbutyugin
Copy link
Collaborator

Sorry to nag, but I think the commit itself should follow that format. You can use git commit --amend to update it (please format the first line as docs: fixed typo in config option name, blank line, then Signed-off-by line). Thanks!

Signed-off-by: Joseph Vilimas 4to5@protonmail.com
@usrhere
Copy link
Contributor Author

usrhere commented Dec 2, 2021

Hope it's ok now :) Thanks for the guidance!

Copy link
Collaborator

@dmbutyugin dmbutyugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@KevinOConnor KevinOConnor merged commit 051133f into Klipper3d:master Dec 2, 2021
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@usrhere usrhere deleted the doc-typo branch December 4, 2021 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants