Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse temperature fan #6156

Closed
wants to merge 2 commits into from

Conversation

dingyifei
Copy link
Contributor

@dingyifei dingyifei commented Apr 7, 2023

Replace #4983 with PID reverse temperature fan implemented as well

Waiting for testers

High-level description:

It flips the sign of temperature difference to reverse the fan on/off

Signed-off-by: Yifei Ding<dingyifeiair@gmail.com>
Co-Authored-By: CF3B5 <11920968+CF3B5@users.noreply.github.com>
@dingyifei dingyifei force-pushed the reverse_temperature_fan branch 2 times, most recently from 3d2491d to 565129f Compare April 7, 2023 21:34
Signed-off-by: Yifei Ding<dingyifeiair@gmail.com>
Co-Authored-By: CF3B5 <11920968+CF3B5@users.noreply.github.com>
@KevinOConnor
Copy link
Collaborator

Thanks. As high-level feedback, it's not clear to me how this is used (and thus how many people might find it useful). If this is to heat a chamber, wouldn't it be simpler to just turn the fan on during chamber heating?

-Kevin

@dewi-ny-je
Copy link

Wouldn't changing sign of pid_Kp do the same?

@jschuh
Copy link
Contributor

jschuh commented May 6, 2023

The use case is where the bed_heater doubles as a weak chamber heater by recirculating air under it, typically by mounting radial fans with the intake facing up in front of the bed and the exhaust just underneath. It's a relatively popular Voron mod.

FWIW, I briefly had a printer set up like this, but I controlled it by configuring the fans as heater_generic with verify_heater settings that ensured it couldn't inadvertently throw a heater_fault. It's a bit hacky, but as I recall it worked fine.

@KevinOConnor
Copy link
Collaborator

Thanks. I think I understand. I'm not sure about this change though. I'm not sure how many users would find it in the config and utilize it.

One of the things I was looking at was extending the "display_template" system to fan_generic - and thus allowing users to set an arbitrary math formula for the fan speed. I wonder if this may be more flexible than adding config entries to temperature_fan.

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label May 11, 2023
@dingyifei
Copy link
Contributor Author

Sounds good. I'll close this now.

@dingyifei dingyifei closed this May 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants