New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(download): drop stream_get_context for Symfony HttpClient #31

Merged

Kocal merged 1 commit into 2.x from feat/download-command-sf-http-client

May 24, 2024

Owner

Kocal commented May 24, 2024 •

edited

Loading

Q	A
Bug fix?	no
New feature?	yes
Tests pass?	yes
Fixed tickets	Close #...

I don't like using file_get_contents for downloading files over HTTP, I prefer using an HTTP Client wrapper (like the SF HttpClient) instead.


          feat(download): drop stream_get_context for Symfony HttpClient

51c8a93

Kocal merged commit 218e8f9 into 2.x

1 of 11 checks passed

Kocal deleted the feat/download-command-sf-http-client branch

May 24, 2024 21:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment