fix(sync): bump go-kong + fill auto fields with nil #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fill auto fields with nil in the config sent to the CP. The rest of the default values are still not filled in the configuration that is sent out, as they are meant to be filled by the CP itself, but auto fields should not be generated, to ensure the configuration remains truly "declarative".
samugi
force-pushed
the
fix/fill-auto-fields-with-nil
branch
from
2b89ba7
to
fdbf4dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
- Coverage 29.97% 29.96% -0.01%
==========================================
Files 106 106
Lines 12581 12583 +2
==========================================
Hits 3771 3771
- Misses 8350 8352 +2
Partials 460 460 ☔ View full report in Codecov by Sentry. |
bungle
requested changes
Sep 4, 2024
bungle
approved these changes
Sep 4, 2024
samugi
changed the title
randmonkey
approved these changes
Sep 5, 2024
randmonkey
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bump go-kong to 0.59.0
use go-kong utils to fill auto fields with nil in the config sent to the CP.
The rest of the default values are still not filled in the configuration that is sent out, as they are meant to be filled by the CP itself.
Full changelog
Issues resolved
https://konghq.atlassian.net/browse/KAG-5317
Documentation
Testing