-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate deck@v1.29.2 library code into this repo #9
Conversation
Between the template hook issue and lack of some lint configuration, this needs #8 first and a rebase after. |
Copy the konnect, cprint, crud, diff, dump, file, scripts, state, types, and utils packages from deck into this repository. The source was imported from deck@v1.29.2: https://github.com/Kong/deck/releases/tag/v1.29.2
Update import references to deck packages migrated to this repository to use the copy in this repository instead of the original in deck. Run: go mod init "github.com/kong/go-database-reconciler" go mod tidy Add replace directive from deck go.mod. Run: go get github.com/alecthomas/jsonschema@v0.0.0-20191017121752-4bb6e3fae4f2 go mod tidy This library is apparently rather out of date in deck and has had breaking changes since it was added. After this downgrade, "go vet ./..." no longer shows errors.
4b6a0d1
to
13ad8e3
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rainest all this is a "hard" copy of the existing decK packages, right? Is there anything specific to call out that differs from the "base" repo? Otherwise, this LGTM (preventively approving this)
It's copying the libraries as-is, yes. Only change is the package paths in internal references. |
Copy the
konnect
,cprint
,crud
,diff
,dump
,file
,scripts
,state
,types
, andutils
packages from https://github.com/Kong/deck/releases/tag/v1.29.2 (also the current tip of main) into this repository'spkg
dir.Update references to those packages from their deck location to this repository.
Run:
Add replace directive from deck go.mod.
Run:
This library is apparently rather out of date in deck and has had breaking changes since it was added. After this downgrade,
go vet ./...
no longer shows errors.