add check for errors and clean service at the end of the test

Kong · Aug 1, 2022 · ba0e275 · ba0e275
1 parent 09da9be
commit ba0e275
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/kong/plugin_service.go b/kong/plugin_service.go
@@ -182,6 +182,9 @@ func (s *PluginService) Delete(ctx context.Context,
 
 	endpoint := fmt.Sprintf("/plugins/%v", *pluginID)
 	_, err := s.sendRequest(ctx, nil, endpoint, "DELETE")
+	if err != nil {
+		return err
+	}
 	return err
 }
 
@@ -198,6 +201,9 @@ func (s *PluginService) DeleteForService(ctx context.Context,
 
 	endpoint := fmt.Sprintf("/services/%v/plugins/%v", *serviceIDorName, *pluginID)
 	_, err := s.sendRequest(ctx, nil, endpoint, "DELETE")
+	if err != nil {
+		return err
+	}
 	return err
 }
 

diff --git a/kong/plugin_service_test.go b/kong/plugin_service_test.go
@@ -119,6 +119,8 @@ func TestPluginsService(T *testing.T) {
 
 	err = client.Plugins.DeleteForService(defaultCtx, createdService.Name, updatedPlugin.ID)
 	assert.NoError(err)
+
+	assert.NoError(client.Services.Delete(defaultCtx, createdService.ID))
 }
 
 func TestPluginWithTags(T *testing.T) {