Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types) add kubebuilder to health types #104

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Dec 7, 2021

Add kubebuilder validation annotation comments to healthcheck-related types. This allows generating schema validation for fields within them in Kubebuilder-generated CRDs. See Kong/kubernetes-ingress-controller#1971 (comment)

Add kubebuilder validation annotation comments to healthcheck-related
types.
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #104 (66c8a6c) into main (acbcf5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   43.49%   43.49%           
=======================================
  Files          42       42           
  Lines        3722     3722           
=======================================
  Hits         1619     1619           
  Misses       1786     1786           
  Partials      317      317           
Flag Coverage Δ
2.0.5 38.04% <ø> (ø)
2.1.4 37.85% <ø> (ø)
2.2.2 37.85% <ø> (ø)
2.3.3 37.85% <ø> (ø)
2.4.0 37.85% <ø> (ø)
community 38.04% <ø> (ø)
enterprise 43.17% <ø> (ø)
enterprise-1.5.0.11 43.17% <ø> (ø)
enterprise-2.1.4.6 42.02% <ø> (ø)
enterprise-2.2.1.3 42.02% <ø> (ø)
enterprise-2.3.3.2 42.02% <ø> (ø)
integration 43.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/types.go 7.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbcf5e...66c8a6c. Read the comment docs.

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit

@shaneutt shaneutt added enhancement New feature or request priority/medium labels Dec 8, 2021
@rainest rainest merged commit c956384 into main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants