Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing entities fields #120

Merged
merged 1 commit into from
Jan 25, 2022
Merged

feat: add missing entities fields #120

merged 1 commit into from
Jan 25, 2022

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@GGabriele GGabriele requested a review from a team as a code owner January 25, 2022 18:31
@hbagdi
Copy link
Member

hbagdi commented Jan 25, 2022

@rainest Can you review this with some git spelunking? Scope includes all relevant entities until Kong 2.8.

@hbagdi hbagdi requested a review from rainest January 25, 2022 18:39
@rainest
Copy link
Contributor

rainest commented Jan 25, 2022

@hbagdi Do you mean specific versions? Something like git diff 2.5.0 -- kong/db/schema/entities/ can tell you what changed between versions, but there's no way to easily know if there's an entity in go-kong missing a field from a version.

@hbagdi
Copy link
Member

hbagdi commented Jan 25, 2022

I meant that could you please do that "git diff" and review this PR to ensure that go-kong is not missing anything that was added in Kong 2.x series (or at least not in the last few releases)?

@rainest
Copy link
Contributor

rainest commented Jan 25, 2022

Looking back to 2.0 (since cert digest is quite old, added in 2.1), manual review did not find anything other than service.enabled, cert digest, and cert/key alts that we're missing in supported core types.

There are new unsupported types:

  • the clustering_data_plane entity, which is only used for reporting status
  • the parameter entity, which looks like an internal helper you don't interact with directly.

All other changes are constraint changes or minor type changes that would not affect the JSON types.

@hbagdi hbagdi merged commit 56266f6 into main Jan 25, 2022
@hbagdi
Copy link
Member

hbagdi commented Jan 25, 2022

Looking forward to a world where this wouldn't be required! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants