chore(ci) change Enterprise test name #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the Enterprise test job name to test-enterprise. Previously it used the same name as the OSS tests, which did weird things to status reporting for community PRs.
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 53.47% 53.47%
=======================================
Files 44 44
Lines 3888 3888
=======================================
Hits 2079 2079
Misses 1353 1353
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shaneutt
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Enterprise test job name to test-enterprise. Previously it used the same name as the OSS tests, which did weird things to status reporting for community PRs.
It looks like using the same name for two jobs in different workflows and making that name a required status makes the status never reported for community PRs, based on observing #192
Best guess since I don't know the internals on GitHub's side, but I figure worst case this doesn't hurt anything since it's just a rename.