Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove license from OSS CI #195

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix: remove license from OSS CI #195

merged 1 commit into from
Aug 5, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Aug 5, 2022

The OSS tests do not need a license, and the environment variable's original presence in them was probably an unnecessary copy-paste. Unfortunately the old variable would be benignly empty for the tests that didn't need it, whereas the new job will actually fail them 😨

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #195 (5de5f61) into main (6124b49) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   53.47%   53.47%           
=======================================
  Files          44       44           
  Lines        3888     3888           
=======================================
  Hits         2079     2079           
  Misses       1353     1353           
  Partials      456      456           
Flag Coverage Δ
2.0.5 39.76% <ø> (ø)
2.1.4 39.60% <ø> (ø)
2.2.2 39.60% <ø> (ø)
2.3.3 39.60% <ø> (ø)
2.4.0 39.60% <ø> (ø)
2.5.1 39.60% <ø> (ø)
2.6.0 39.60% <ø> (ø)
2.7.0 39.60% <ø> (ø)
2.8.0 39.60% <ø> (ø)
community 39.76% <ø> (ø)
enterprise 52.08% <ø> (ø)
enterprise-1.5.0.11 52.08% <ø> (ø)
enterprise-2.1.4.6 51.08% <ø> (ø)
enterprise-2.2.1.3 51.08% <ø> (ø)
enterprise-2.3.3.4 51.08% <ø> (ø)
enterprise-2.4.1.3 51.08% <ø> (ø)
enterprise-2.5.1.2 51.08% <ø> (ø)
enterprise-2.6.0.2 51.08% <ø> (ø)
enterprise-2.7.0.0 51.08% <ø> (ø)
enterprise-2.8.0.0 51.08% <ø> (ø)
integration 53.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rainest rainest merged commit 0ff6a84 into main Aug 5, 2022
@rainest rainest deleted the fix/oss-license branch August 5, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants