-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support JSON schemas in the FillEntityDefaults function #231
Conversation
68057cc
to
23ff0f8
Compare
FillEntityDefaults can be used to inject Kong entity defaults into a Kong entity struct. This function achieves this by getting entity schemas from the Admin API, flattening the returned schemas and merging these with the input schemas. Kong CP only works with Lua schemas, while Konnect also supports JSON schemas. This commit adds support to filling entity defaults from JSON schemas.
23ff0f8
to
31bb22f
Compare
Codecov ReportBase: 53.01% // Head: 53.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 53.01% 53.39% +0.38%
==========================================
Files 46 46
Lines 4142 4178 +36
==========================================
+ Hits 2196 2231 +35
- Misses 1469 1470 +1
Partials 477 477
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
FillEntityDefaults can be used to inject Kong entity defaults into a Kong entity struct. This function achieves this by getting entity schemas from the Admin API, flattening the returned schemas and merging these with the input schemas.
Kong CP only works with Lua schemas, while Konnect also supports JSON schemas.
This commit adds support to filling entity defaults from JSON schemas.