Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IsForbiddenErr error checking for 403s #264

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

GGabriele
Copy link
Collaborator

No description provided.

kong/error_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Base: 52.43% // Head: 52.84% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (102506c) compared to base (e0fcd03).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   52.43%   52.84%   +0.40%     
==========================================
  Files          51       51              
  Lines        4621     4627       +6     
==========================================
+ Hits         2423     2445      +22     
+ Misses       1670     1659      -11     
+ Partials      528      523       -5     
Flag Coverage Δ
2.1.4 35.72% <71.42%> (+0.42%) ⬆️
2.2.1.3 45.86% <85.71%> (+0.58%) ⬆️
2.2.2 35.72% <71.42%> (+0.42%) ⬆️
2.3.3 37.45% <71.42%> (+0.42%) ⬆️
2.3.3.4 45.86% <85.71%> (+0.58%) ⬆️
2.4.0 37.54% <71.42%> (+0.42%) ⬆️
2.4.1.3 45.86% <85.71%> (+0.58%) ⬆️
2.5.1 37.54% <71.42%> (+0.42%) ⬆️
2.5.1.2 45.86% <85.71%> (+0.58%) ⬆️
2.6.0 37.54% <71.42%> (+0.42%) ⬆️
2.6.0.2 45.86% <85.71%> (+0.58%) ⬆️
2.7.0 37.54% <71.42%> (+0.42%) ⬆️
2.7.0.0 47.54% <85.71%> (+0.58%) ⬆️
2.8.0 37.54% <71.42%> (+0.42%) ⬆️
2.8.2.2 47.54% <85.71%> (+0.58%) ⬆️
3.0.1 36.93% <71.42%> (+0.42%) ⬆️
3.0.1.0 48.04% <85.71%> (+0.58%) ⬆️
3.1.0 38.57% <71.42%> (+0.42%) ⬆️
3.1.0.0 49.68% <85.71%> (+0.58%) ⬆️
community 39.18% <71.42%> (+0.42%) ⬆️
enterprise 50.29% <85.71%> (+0.58%) ⬆️
integration 52.84% <85.71%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/error.go 95.23% <83.33%> (+8.57%) ⬆️
kong/test_utils.go 47.50% <100.00%> (ø)
kong/client.go 65.88% <0.00%> (+2.80%) ⬆️
kong/consumer_service.go 63.15% <0.00%> (+5.26%) ⬆️
kong/list.go 93.47% <0.00%> (+6.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GGabriele GGabriele force-pushed the feat/license-error branch 5 times, most recently from b1e27cf to ec4e876 Compare January 13, 2023 09:28
@GGabriele GGabriele requested a review from pmalek January 13, 2023 09:38
kong/error_test.go Outdated Show resolved Hide resolved
kong/error_test.go Outdated Show resolved Hide resolved
kong/error_test.go Outdated Show resolved Hide resolved
@pmalek pmalek added the enhancement New feature or request label Jan 13, 2023
@GGabriele GGabriele merged commit b5092e8 into main Jan 13, 2023
@GGabriele GGabriele deleted the feat/license-error branch January 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants