-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Route's priority type to uint64 #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 53.05% 53.16% +0.10%
==========================================
Files 69 69
Lines 5200 5212 +12
==========================================
+ Hits 2759 2771 +12
Misses 1857 1857
Partials 584 584
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Oct 27, 2023
pmalek
force-pushed
the
update-route-priority-type-to-int64
branch
from
October 27, 2023 10:01
5cb7d52
to
e032ab7
Compare
czeslavo
approved these changes
Oct 27, 2023
pmalek
force-pushed
the
update-route-priority-type-to-int64
branch
from
October 30, 2023 09:05
e032ab7
to
7561761
Compare
pmalek
changed the title
fix: update Route's priority type to int64
fix: update Route's priority type to uint64
Oct 30, 2023
pmalek
force-pushed
the
update-route-priority-type-to-int64
branch
from
October 30, 2023 09:09
7561761
to
fe7dcba
Compare
pmalek
force-pushed
the
update-route-priority-type-to-int64
branch
from
October 30, 2023 09:09
fe7dcba
to
4e723d2
Compare
randmonkey
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route's priority in expression routes should be of type
uint64
instead of int.There's a related (linked in the comment) issue for Gateway which returns integers in scientific notation: https://konghq.atlassian.net/browse/FTI-5515. When that's solved the commented test case should be uncommented.
Also update the changelog to release 0.48.0.