Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Route's priority type to uint64 #378

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 27, 2023

Route's priority in expression routes should be of type uint64 instead of int.


There's a related (linked in the comment) issue for Gateway which returns integers in scientific notation: https://konghq.atlassian.net/browse/FTI-5515. When that's solved the commented test case should be uncommented.


Also update the changelog to release 0.48.0.

@pmalek pmalek self-assigned this Oct 27, 2023
@pmalek pmalek requested a review from a team as a code owner October 27, 2023 09:37
@pmalek pmalek requested a review from a team October 27, 2023 09:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (847d46d) 53.05% compared to head (4e723d2) 53.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   53.05%   53.16%   +0.10%     
==========================================
  Files          69       69              
  Lines        5200     5212      +12     
==========================================
+ Hits         2759     2771      +12     
  Misses       1857     1857              
  Partials      584      584              
Flag Coverage Δ
2.1 33.15% <58.33%> (+0.05%) ⬆️
2.2 33.15% <58.33%> (-11.43%) ⬇️
2.3 45.31% <58.33%> (+0.03%) ⬆️
2.4 33.28% <58.33%> (-12.08%) ⬇️
2.5 45.39% <58.33%> (+0.02%) ⬆️
2.6 45.39% <58.33%> (+0.02%) ⬆️
2.7 33.28% <58.33%> (-13.58%) ⬇️
2.8 33.28% <58.33%> (-13.58%) ⬇️
3.0 50.61% <75.00%> (+0.05%) ⬆️
3.1 52.07% <75.00%> (+0.05%) ⬆️
3.2 52.12% <75.00%> (+0.05%) ⬆️
3.3 52.12% <75.00%> (+0.05%) ⬆️
3.4 52.45% <75.00%> (+0.05%) ⬆️
community 38.37% <100.00%> (+0.14%) ⬆️
enterprise 51.84% <100.00%> (+0.11%) ⬆️
enterprise-nightly 50.80% <75.00%> (?)
integration 53.16% <100.00%> (+0.10%) ⬆️
nightly 37.66% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kong/route.go 0.00% <ø> (ø)
kong/test_utils.go 62.50% <100.00%> (+2.79%) ⬆️
kong/utils.go 88.37% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kong/route.go Outdated Show resolved Hide resolved
@pmalek pmalek force-pushed the update-route-priority-type-to-int64 branch from 5cb7d52 to e032ab7 Compare October 27, 2023 10:01
@pmalek pmalek force-pushed the update-route-priority-type-to-int64 branch from e032ab7 to 7561761 Compare October 30, 2023 09:05
@pmalek pmalek changed the title fix: update Route's priority type to int64 fix: update Route's priority type to uint64 Oct 30, 2023
@pmalek pmalek enabled auto-merge (squash) October 30, 2023 09:08
@pmalek pmalek force-pushed the update-route-priority-type-to-int64 branch from 7561761 to fe7dcba Compare October 30, 2023 09:09
@pmalek pmalek force-pushed the update-route-priority-type-to-int64 branch from fe7dcba to 4e723d2 Compare October 30, 2023 09:09
@pmalek pmalek requested a review from czeslavo October 30, 2023 09:10
@pmalek pmalek merged commit 5e2f65b into main Oct 30, 2023
67 checks passed
@pmalek pmalek deleted the update-route-priority-type-to-int64 branch October 30, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants