Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract details from response #399

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Conversation

randmonkey
Copy link
Contributor

Extract details field from response if error happens in calling admin API on Konnect to do CRUD of entities. fixes #398.

@randmonkey randmonkey requested a review from a team as a code owner January 12, 2024 07:27
@randmonkey randmonkey requested a review from a team January 12, 2024 07:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b34bcbb) 53.07% compared to head (d23b9c2) 53.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   53.07%   53.18%   +0.10%     
==========================================
  Files          69       69              
  Lines        5247     5259      +12     
==========================================
+ Hits         2785     2797      +12     
  Misses       1876     1876              
  Partials      586      586              
Flag Coverage Δ
2.1 33.35% <100.00%> (+0.15%) ⬆️
2.2 44.70% <100.00%> (+0.12%) ⬆️
2.3 45.40% <100.00%> (+0.12%) ⬆️
2.4 45.48% <100.00%> (+0.12%) ⬆️
2.5 45.48% <100.00%> (+0.12%) ⬆️
2.6 45.48% <100.00%> (+0.12%) ⬆️
2.7 46.96% <100.00%> (+0.12%) ⬆️
2.8 46.96% <100.00%> (+0.12%) ⬆️
3.0 50.65% <100.00%> (+0.11%) ⬆️
3.1 52.10% <100.00%> (+0.10%) ⬆️
3.2 52.15% <100.00%> (+0.10%) ⬆️
3.3 52.15% <100.00%> (+0.10%) ⬆️
3.4 52.48% <100.00%> (+0.10%) ⬆️
community 38.52% <100.00%> (+0.14%) ⬆️
enterprise 51.87% <100.00%> (+0.11%) ⬆️
enterprise-nightly 50.84% <100.00%> (+0.11%) ⬆️
integration 53.18% <100.00%> (+0.10%) ⬆️
nightly 37.82% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey force-pushed the feat/extract_details_from_resp branch from 0664d33 to f6d8699 Compare January 12, 2024 07:32
kong/response.go Outdated Show resolved Hide resolved
@randmonkey randmonkey merged commit 19b8bfa into main Jan 16, 2024
67 checks passed
@randmonkey randmonkey deleted the feat/extract_details_from_resp branch January 16, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse details field in error response from Konnect of entity CRUD requests
3 participants