-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: validate type assertion to prevent panic #436
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 59.44% 59.42% -0.03%
==========================================
Files 71 71
Lines 4392 4394 +2
==========================================
Hits 2611 2611
- Misses 1170 1171 +1
- Partials 611 612 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is presumably caused by the test checking the admin API before it's properly available. We should try to make that not happen, but I suppose this is at least slightly better than the panic.
I observed panics couple of times in tests. Validating type assertion before proceeding further should prevent this panic.