Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return APIError from ReloadDeclarativeRawConfig #452

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jun 24, 2024

Makes ReloadDeclarativeRawConfig return an APIError when the status code is <200 or >=400.
KIC needs to inspect the HTTP response status code when invoking ReloadDeclarativeRawConfig to decide whether it's a recoverable issue (4xx) or not (5xx).

Required for Kong/kubernetes-ingress-controller#6237.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.57%. Comparing base (992aa54) to head (99cb2b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   59.41%   59.57%   +0.15%     
==========================================
  Files          71       71              
  Lines        4408     4408              
==========================================
+ Hits         2619     2626       +7     
+ Misses       1174     1168       -6     
+ Partials      615      614       -1     
Flag Coverage Δ
2.1 35.82% <0.00%> (ø)
2.2 48.34% <0.00%> (ø)
2.3 48.97% <0.00%> (ø)
2.4 49.02% <0.00%> (ø)
2.5 49.02% <0.00%> (ø)
2.6 49.02% <0.00%> (ø)
2.7 50.72% <0.00%> (ø)
2.8 50.72% <0.00%> (ø)
3.0 54.85% <100.00%> (+0.20%) ⬆️
3.1 56.48% <100.00%> (+0.20%) ⬆️
3.2 56.48% <100.00%> (+0.15%) ⬆️
3.3 56.48% <100.00%> (+0.15%) ⬆️
3.4 58.87% <100.00%> (+0.15%) ⬆️
3.5 56.66% <100.00%> (+0.15%) ⬆️
3.6 56.66% <100.00%> (+0.15%) ⬆️
community 43.62% <100.00%> (+0.15%) ⬆️
enterprise 58.03% <0.00%> (ø)
integration 59.57% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo marked this pull request as ready for review June 24, 2024 17:00
@czeslavo czeslavo requested a review from a team as a code owner June 24, 2024 17:00
@czeslavo czeslavo requested a review from a team June 24, 2024 17:00
@czeslavo czeslavo requested a review from a team as a code owner June 24, 2024 17:00
@czeslavo czeslavo merged commit c2f2a77 into main Jun 25, 2024
79 checks passed
@czeslavo czeslavo deleted the feat/apierror-from-reload branch June 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants