Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle workspace in Kong's client #62
Handle workspace in Kong's client #62
Changes from 10 commits
5d4ac09
e2feb46
810fa48
ff86895
0647e60
4237ad7
10fb929
f1665ac
0a731c8
a4ba5b2
c683acd
bb166ea
97d8295
ae4ecaf
ee8b17c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we rename baseURL to
url
?I think it makes the signature a bit more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using url would mean using the full one, isn't it?
As it's always concatenated with the endpoint parameter, wouldn't it lead to confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misunderstood. @mflendrich Should we name these as
NewWorkspacedRequest
NewRequest
and then appropriate docs comment? The current API in this patch is not very easy to grok.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to achieve two results:
NewRequest
Maybe we can relax the former. In that situation, we could do the following movements:
NewRequest
toNewRequestCurrentWorkspace
NewRequestRaw
toNewRequestForBaseURL
and say explicitly in the docstring that this expects the workspace URL to be passed as the base URL.WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bit more descriptive?