Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define FriendlyName for the entities, based on deck/state/types.go #68

Merged
merged 6 commits into from
Jul 1, 2021
Merged

Define FriendlyName for the entities, based on deck/state/types.go #68

merged 6 commits into from
Jul 1, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 27, 2021

This feature add identifier methods to entities to allow to print names or ids depending on which one is available.
It will offer a clean solution for Kong/deck#417

@mmorel-35 mmorel-35 requested a review from a team as a code owner May 27, 2021 07:25
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #68 (4b731f0) into main (26f0e0e) will decrease coverage by 6.60%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   45.59%   38.98%   -6.61%     
==========================================
  Files          41       41              
  Lines        2553     2606      +53     
==========================================
- Hits         1164     1016     -148     
- Misses       1085     1338     +253     
+ Partials      304      252      -52     
Flag Coverage Δ
2.0.5 38.98% <0.00%> (-0.81%) ⬇️
2.1.4 38.75% <0.00%> (-0.81%) ⬇️
2.2.2 38.75% <0.00%> (-0.81%) ⬇️
2.3.3 38.75% <0.00%> (-0.81%) ⬇️
2.4.0 38.75% <0.00%> (-0.81%) ⬇️
community 38.98% <0.00%> (-0.81%) ⬇️
enterprise ?
enterprise-1.5.0.11 ?
enterprise-2.1.4.6 ?
enterprise-2.2.1.3 ?
enterprise-2.3.3.2 ?
integration 38.98% <0.00%> (-6.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/types.go 5.20% <0.00%> (-6.42%) ⬇️
kong/mtls_auth_service.go 0.00% <0.00%> (-66.16%) ⬇️
kong/workspace_service.go 0.00% <0.00%> (-56.67%) ⬇️
kong/admin_service.go 0.00% <0.00%> (-21.52%) ⬇️
kong/credentials.go 85.71% <0.00%> (-14.29%) ⬇️
kong/utils.go 71.42% <0.00%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f0e0e...4b731f0. Read the comment docs.

kong/identifiers.go Outdated Show resolved Hide resolved
kong/identifiers.go Outdated Show resolved Hide resolved
kong/identifiers.go Outdated Show resolved Hide resolved
kong/identifiers.go Outdated Show resolved Hide resolved
kong/identifiers.go Outdated Show resolved Hide resolved
kong/identifiers.go Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 changed the title Define identifiers for the entities, based on deck/state/types.go Define FriendlyName for the entities, based on deck/state/types.go May 29, 2021
@mmorel-35
Copy link
Contributor Author

Hi @mflendrich, anything left to do here?

@mflendrich mflendrich merged commit f1ae08c into Kong:main Jul 1, 2021
@mmorel-35 mmorel-35 deleted the feature/identifiers branch July 1, 2021 15:34
@mmorel-35
Copy link
Contributor Author

Any idea when is planned the next release for go-kong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants