Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(e2e): List entities instead of dump.Get to fetch Kong config in e2e tests #6358

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Test(e2e): List entities instead of dump.Get to fetch Kong config in e2e tests #6358

merged 4 commits into from
Aug 1, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jul 30, 2024 •
edited
Loading

What this PR does / why we need it:

List Services, Routes, Upstreams and Targets to verify Kong configuration in gateway pods in verifyIngressWithEchoBackendsInAdminAPI instead of dump.Get. This could reduce the concurrency of streams to forwarded ports.

e2e run passes: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/10173800539.

Which issue this PR fixes:

Fixes #6317
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR No need to update changelog.

@randmonkey randmonkey added the ci/run-e2e Trigger e2e test run from PR label Jul 30, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/10160735452

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 30, 2024
@randmonkey randmonkey added the ci/run-e2e Trigger e2e test run from PR label Jul 31, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/10173800539

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 31, 2024
@randmonkey randmonkey changed the title WIP try lock for longer in GetFreePort Test(e2e): List entities instead of dump.Get to fetch Kong config in e2e tests Jul 31, 2024
@randmonkey randmonkey marked this pull request as ready for review July 31, 2024 05:56
@randmonkey randmonkey requested a review from a team as a code owner July 31, 2024 05:56
pmalek
pmalek reviewed Jul 31, 2024
View reviewed changes
test/e2e/helpers_test.go Outdated Show resolved Hide resolved
test/e2e/helpers_test.go Outdated Show resolved Hide resolved
test/e2e/helpers_test.go Outdated Show resolved Hide resolved
test/e2e/helpers_test.go Outdated Show resolved Hide resolved
@randmonkey randmonkey requested a review from pmalek August 1, 2024 02:46
@randmonkey randmonkey added the ci/run-e2e Trigger e2e test run from PR label Aug 1, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/10191095350

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Aug 1, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b85dbb1). Learn more about missing BASE report.

Additional details and impacted files 
@@          Coverage Diff           @@
##             main   #6358   +/-   ##
======================================
  Coverage        ?   74.0%           
======================================
  Files           ?     200           
  Lines           ?   20179           
  Branches        ?       0           
======================================
  Hits            ?   14942           
  Misses          ?    4244           
  Partials        ?     993

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/10193698357

@randmonkey randmonkey merged commit cf74455 into main Aug 1, 2024
89 checks passed
@randmonkey randmonkey deleted the test/fix_e2e_portForward branch August 1, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@pmalek pmalek Awaiting requested review from pmalek

Assignees
No one assigned
Labels
area/tests size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e test TestDeployAllInOneDBLESS fails on kind environment
4 participants
@randmonkey @team-k8s-bot @pmalek @tao12345666333