-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Kuma updates to 0.39 #1017
Conversation
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.39.x #1017 +/- ##
==================================================
- Coverage 59.88% 59.84% -0.05%
==================================================
Files 48 48
Lines 3914 3925 +11
==================================================
+ Hits 2344 2349 +5
- Misses 1275 1279 +4
- Partials 295 297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
According to @czeslavo discovered, After we add the |
82fb74a
to
dc36637
Compare
8e50acd
to
7107635
Compare
7107635
to
481e0ba
Compare
Backport fe761fa and 7816472 to 0.39 and release 0.39.2.
Update CI to test on PRs to release branches. Update license handling for this release branch.
KIC 2.12 is able to pass E2E with this in place: Kong/kubernetes-ingress-controller#5760 (comment)
This technically breaks semver, but we don't really have anywhere else to stuff it. Maybe you can call the addon not supporting version args and not supporting 2.6 "bugs" for the sake of discussion 🤷
Updating KIC 2.x to use the latest KTF causes all sorts of conflicts due to dependency hell with packages that both KTF and KIC import. We don't have a compelling need to actually update those in 2.x, so trying to make a backported KTF version that can run Kuma tests without pulling updates is much simpler.
@randmonkey can you confirm the exact nature of the Kuma failures? Was it just that it was trying to use latest without the 2.6 fix? IDK if we'd also need to pin the Kuma version in the 2.x KIC tests after this.